chore: add a bit of delay to reduce Modal test flakiness #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #1801 +/- ##
==========================================
- Coverage 92.61% 92.50% -0.11%
==========================================
Files 147 147
Lines 2735 2735
Branches 712 712
==========================================
- Hits 2533 2530 -3
- Misses 187 189 +2
- Partials 15 16 +1 see 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
size-limit report 📦
|
|
Thanks for this. It started happening after some version update last week, which is peculiar 🤔 |
booc0mtaco
approved these changes
Nov 7, 2023
|
Yeah, kind of odd. Maybe headless updated something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some flakiness with the Modal's interactive examples tests. Fixed here by adding a small delay.
Alternatively could try to wait for a specific class. But I don't think there's a good one. The classes in question seem to be generated, and I don't want to rely on them.